Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty data view and welcome screen appearing when ent search is enabled #127260

Merged
merged 9 commits into from
Mar 15, 2022
Merged

Fix empty data view and welcome screen appearing when ent search is enabled #127260

merged 9 commits into from
Mar 15, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Mar 9, 2022 •
edited
Loading

Summary

Fixes #127787

  • For 8.1.x+ this fixes an empty state of "Create data view flyout": it treats data stream created by default by enterprise search logs-enterprise_search.api-default as non-user created one so that "Create data view flyout" flyout shows "No data state" instead of "You have data, now create data view".
  • For 8.0.x this also fixes presenting of a "Welcome to Elastic / Start by adding integrations" screen when ent search is enabled. This isn't broken in 8.1 because of Fleet system package installs 15 Dashboards, 120+ Visualizations and 2 Kibana index-patterns #82851 that landed in 8.1 no longer backporting to 8.0

Longer-term we probably can remove specific handling for logs-*, metrics-* data views because #82851 is fixed. We also need to work with enterprise search to address specific handling of logs-enterprise_search.api-default. Probably we can do it as part of #124019

@Dosant Dosant changed the title D/2022 03 08 has index patterns fix Fix empty data view and welcome screen appearing Mar 9, 2022
@Dosant Dosant changed the title Fix empty data view and welcome screen appearing Fix empty data view and welcome screen appearing when ent search is enabled Mar 9, 2022
@Dosant
Copy link
Contributor Author

Dosant commented Mar 9, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Mar 9, 2022

@elasticmachine merge upstream

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes v8.0.2 v8.1.1 v8.2.0 Team:AppServicesSv labels Mar 9, 2022
@Dosant Dosant marked this pull request as ready for review March 9, 2022 16:55
@Dosant Dosant requested a review from a team as a code owner March 9, 2022 16:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant Dosant requested review from mattkime, shivindera and afharo March 9, 2022 16:55
@mattkime
Copy link
Contributor

mattkime commented Mar 9, 2022 •
edited
Loading

Lets check in with enterprise search first to see what their needs are. I'd like to work towards an official stance of 'no data streams or indices without user interaction'

More discussion - #127332

afharo
afharo approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and it works! Thanks for fixing it!

image

@Dosant Dosant removed the v8.0.2 label Mar 15, 2022
@Dosant
Copy link
Contributor Author

Dosant commented Mar 15, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Mar 15, 2022

@elasticmachine merge upstream

mattkime
mattkime approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm!

@Dosant
Copy link
Contributor Author

Dosant commented Mar 15, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2831 2832 +1
dataViews 644 645 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 114.4KB 114.5KB +91.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 456.9KB 456.9KB +4.0B
dataViews 40.4KB 40.5KB +81.0B
total +85.0B
Unknown metric groups

API count

id before after diff
data 3444 3445 +1
dataViews 796 797 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 1cbe1f3 into elastic:main Mar 15, 2022
@Dosant Dosant added auto-backport Deprecated - use backport:version if exact versions are needed and removed ci:deploy-cloud auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 15, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 127260

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 127260

Questions ?

Please refer to the Backport tool documentation

@Dosant Dosant mentioned this pull request Mar 15, 2022
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Mar 15, 2022
@Dosant
Fix empty data view and welcome screen appearing when ent search is e…
285fb88 
…nabled (elastic#127260)

(cherry picked from commit 1cbe1f3)

# Conflicts:
#	src/plugins/data_views/server/has_user_index_pattern.ts
Dosant added a commit that referenced this pull request Mar 16, 2022
@Dosant @kibanamachine
[8.1] Fix empty data view and welcome screen appearing when ent searc…
c35c2fd 
…h is enabled (#127260) (#127815)

* Fix empty data view and welcome screen appearing when ent search is enabled (#127260)

(cherry picked from commit 1cbe1f3)

# Conflicts:
#	src/plugins/data_views/server/has_user_index_pattern.ts

* fix unit test

Co-authored-by: Kibana Machine <[email protected]>
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@Dosant @maksimkovalev
Fix empty data view and welcome screen appearing when ent search is e…
c89bff3 
…nabled (elastic#127260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

@shivindera shivindera shivindera approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty "create data view" and welcome screen broken when ent search is enabled
7 participants
@Dosant @elasticmachine @mattkime @kibana-ci @kibanamachine @shivindera @afharo