Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Automate docs for push case and case case config APIs #144657

Merged
merged 8 commits into from
Nov 8, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 5, 2022

Summary

Relates to #137240

This PR uses the open API v3 specification (OAS) to generate output for the following APIs:

  • push case
  • set case configuration
  • update case configuration
  • get case configuration

It takes output from the open-api generator, in particular the HTML generator, applies a custom template and uses that output in a passthrough block in an appendix in the Kibana Guide.

A notable change to the existing OAS is that I've changed the request body in push case from {} to a nullable object, since otherwise the open API generator returned this error:

Exception: Request body cannot be null. Possible cause: missing schema in body parameter

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Documentation preview:

@lcawl lcawl added docs Feature:Cases Cases feature v8.6.0 v8.5.1 Team:Docs Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Docs labels Nov 5, 2022
@lcawl lcawl changed the title [DOCS] Automate docs for push case API [DOCS] Automate docs for push case and update case config APIs Nov 5, 2022
@lcawl lcawl changed the title [DOCS] Automate docs for push case and update case config APIs [DOCS] Automate docs for push case and case case config APIs Nov 5, 2022
@lcawl lcawl requested a review from a team November 7, 2022 15:33
@lcawl lcawl marked this pull request as ready for review November 7, 2022 15:33
@lcawl lcawl requested a review from a team as a code owner November 7, 2022 15:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Nov 7, 2022
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl added the backport:skip This commit does not require backporting label Nov 8, 2022
@lcawl lcawl merged commit 9bf262d into elastic:main Nov 8, 2022
@lcawl
Copy link
Contributor Author

lcawl commented Nov 8, 2022

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Nov 8, 2022
lcawl added a commit that referenced this pull request Nov 8, 2022
…144657) (#144832)

# Backport

This will backport the following commits from `main` to `8.5`:
- [[DOCS] Automate docs for push case and case case config APIs
(#144657)](#144657)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-08T17:34:52Z","message":"[DOCS]
Automate docs for push case and case case config APIs
(#144657)","sha":"9bf262dd1c1660528e6388b8ae257c41d18c3884","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:ResponseOps","docs","Feature:Cases","v8.6.0","v8.5.1"],"number":144657,"url":"https://github.com/elastic/kibana/pull/144657","mergeCommit":{"message":"[DOCS]
Automate docs for push case and case case config APIs
(#144657)","sha":"9bf262dd1c1660528e6388b8ae257c41d18c3884"}},"sourceBranch":"main","suggestedTargetBranches":["8.5"],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/144657","number":144657,"mergeCommit":{"message":"[DOCS]
Automate docs for push case and case case config APIs
(#144657)","sha":"9bf262dd1c1660528e6388b8ae257c41d18c3884"}},{"branch":"8.5","label":"v8.5.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants