Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Remove preconfiguration API route #147199

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Dec 7, 2022

Summary

Resolve #146177

Remove the /api/fleet/setup/preconfiguration API that route was used to test preconfiguration, but it should not be used by end user as the source of truth for preconfigured agent policies is the kibana.yml file and using that API can cause some bugs.

Release note

Remove the /api/fleet/setup/preconfiguration API, that route was made public by accident and not should be used by end user as the only way to manage preconfigured agent policy is through kibana config file.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 labels Dec 7, 2022
@nchaulet nchaulet self-assigned this Dec 7, 2022
@nchaulet nchaulet requested a review from a team as a code owner December 7, 2022 16:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

nchaulet commented Dec 7, 2022

@elasticmachine merge upstream

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpollich
Copy link
Member

kpollich commented Dec 7, 2022

This should probably get a release note label on the off chance a user was relying on this API.

@nchaulet nchaulet added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 7, 2022
@nchaulet nchaulet enabled auto-merge (squash) December 7, 2022 17:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 120.5KB 120.5KB -51.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 29d2745 into elastic:main Dec 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 7, 2022
@nchaulet nchaulet deleted the feature-remove-preconfiguration-endpoint branch January 31, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:breaking Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Deprecate remove /api/fleet/setup/preconfiguration
6 participants