Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing disabled style changes #206372

Closed
wants to merge 2 commits into from

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jan 11, 2025

Summary

Testing changes for input to prioritize disabled over readonly, see elastic/eui#8271.

These changes are shown to have no impact to functional tests. See buildkite build.

@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 11, 2025
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Sorry, something went wrong.

@nickofthyme nickofthyme force-pushed the testing-disabled-styles branch from 54d7eb5 to 7eb2cd8 Compare January 13, 2025 15:27
@elastic elastic deleted a comment from elasticmachine Jan 13, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / CasesWebhookActionConnectorFields renders Validation validates correctly "webhookCreateUrlText"
  • [job] [logs] Jest Tests #15 / CasesWebhookActionConnectorFields renders Validation validates correctly "webhookPasswordInput"
  • [job] [logs] FTR Configs #76 / visualize app visual builder Time Series Elastic charts should display correct chart data, label names and area colors for sum aggregation when split by terms

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 508.0KB 508.4KB +394.0B
dashboard 687.9KB 688.3KB +394.0B
kubernetesSecurity 257.9KB 258.3KB +394.0B
maps 3.1MB 3.1MB +394.0B
ml 4.7MB 4.7MB +394.0B
visTypeVega 1.9MB 1.9MB +394.0B
total +2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.9MB 5.9MB +330.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants