Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Fix agent logs link to Logs Explorer in security space #207303

Merged
merged 9 commits into from
Jan 31, 2025
Merged

[8.x] Fix agent logs link to Logs Explorer in security space #207303

merged 9 commits into from
Jan 31, 2025

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Jan 21, 2025 •
edited
Loading

Resolves #204973

Summary

Fix agent logs link to Logs Explorer in security space in 8.x

@elastic elastic deleted a comment from elasticmachine Jan 21, 2025
@thomheymann thomheymann changed the title Agent logs link to Logs Explorer in security space Fix agent logs link to Logs Explorer in security space Jan 21, 2025
@thomheymann thomheymann added release_note:fix backport:skip This commit does not require backporting labels Jan 21, 2025
@thomheymann thomheymann changed the title Fix agent logs link to Logs Explorer in security space [8.x] Fix agent logs link to Logs Explorer in security space Jan 21, 2025
@thomheymann thomheymann marked this pull request as ready for review January 21, 2025 15:39
@thomheymann thomheymann requested a review from a team January 27, 2025 14:30
@thomheymann thomheymann added the Team:obs-ux-logs Observability Logs User Experience Team label Jan 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jan 28, 2025
@elastic elastic deleted a comment from elasticmachine Jan 29, 2025
@elastic elastic deleted a comment from elasticmachine Jan 29, 2025
@thomheymann thomheymann enabled auto-merge (squash) January 29, 2025 15:22
@weltenwort weltenwort self-requested a review January 30, 2025 10:33
weltenwort
weltenwort requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this, I left a few questions below

...ications/fleet/sections/agents/agent_details_page/components/agent_logs/view_logs_button.tsx Outdated Show resolved Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/view_logs_button.tsx Outdated Show resolved Hide resolved
x-pack/platform/plugins/shared/logs_shared/public/plugin.tsx Show resolved Hide resolved
x-pack/platform/plugins/shared/logs_shared/common/locators/index.ts Show resolved Hide resolved
x-pack/platform/plugins/shared/logs_shared/common/locators/discover_logs_locator.ts Show resolved Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/view_logs_button.tsx Outdated Show resolved Hide resolved
weltenwort
weltenwort approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@thomheymann thomheymann merged commit 53a281d into elastic:8.x Jan 31, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
logsShared 368 369 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
logsShared 287 291 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +115.0B
logsShared 332.5KB 332.5KB -5.0B
total +110.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logsShared 174.8KB 175.8KB +1.0KB
Unknown metric groups

API count

id before after diff
logsShared 316 321 +5

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomheymann @elasticmachine @weltenwort @kibanamachine