[Streams] Schema Editor refresh button #208093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
release_note:skip
flash1293
approved these changes
Jan 28, 2025
…bana into schema-editor-refresh-button
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @Kerry350 |
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 31, 2025
## Summary Implements: elastic#207066 (comment) I'm not sure how "smart" we need this to be. The `<EuiProgress />` component already shows when either of these requests are running, but the table doesn't auto-scroll back to the top when items are reloaded (for example). --------- Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9936dee)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 31, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Streams] Schema Editor refresh button (#208093)](#208093) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-31T12:32:48Z","message":"[Streams] Schema Editor refresh button (#208093)\n\n## Summary\r\n\r\nImplements:\r\nhttps://github.com//pull/207066#issuecomment-2609651683\r\n\r\nI'm not sure how \"smart\" we need this to be. The `<EuiProgress />`\r\ncomponent already shows when either of these requests are running, but\r\nthe table doesn't auto-scroll back to the top when items are reloaded\r\n(for example).\r\n\r\n---------\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9936dee95d5c1dddfd496e3307847782523bb15f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","Feature:Streams","v9.1.0","v8.19.0"],"title":"[Streams] Schema Editor refresh button","number":208093,"url":"https://github.com/elastic/kibana/pull/208093","mergeCommit":{"message":"[Streams] Schema Editor refresh button (#208093)\n\n## Summary\r\n\r\nImplements:\r\nhttps://github.com//pull/207066#issuecomment-2609651683\r\n\r\nI'm not sure how \"smart\" we need this to be. The `<EuiProgress />`\r\ncomponent already shows when either of these requests are running, but\r\nthe table doesn't auto-scroll back to the top when items are reloaded\r\n(for example).\r\n\r\n---------\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9936dee95d5c1dddfd496e3307847782523bb15f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208093","number":208093,"mergeCommit":{"message":"[Streams] Schema Editor refresh button (#208093)\n\n## Summary\r\n\r\nImplements:\r\nhttps://github.com//pull/207066#issuecomment-2609651683\r\n\r\nI'm not sure how \"smart\" we need this to be. The `<EuiProgress />`\r\ncomponent already shows when either of these requests are running, but\r\nthe table doesn't auto-scroll back to the top when items are reloaded\r\n(for example).\r\n\r\n---------\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9936dee95d5c1dddfd496e3307847782523bb15f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements: #207066 (comment)
I'm not sure how "smart" we need this to be. The
<EuiProgress />component already shows when either of these requests are running, but the table doesn't auto-scroll back to the top when items are reloaded (for example).