Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR] Skipped basic license tests for FIPS #208916

Merged
merged 6 commits into from
Jan 31, 2025
Merged

[FTR] Skipped basic license tests for FIPS #208916

merged 6 commits into from
Jan 31, 2025

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented Jan 30, 2025 •
edited
Loading

Summary

All tests in deployment_agnostic/security_and_spaces/stateful.config_basic.ts and deployment_agnostic/security_and_spaces/stateful.copy_to_space.config_basic.ts are intended to be run only with basic license, since FIPS overrides it we need to skip that test for FIPS.

Separated index entries for basic and trial license, so tests with trial config would still run.

Checklist

@elena-shostak elena-shostak added FTR release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 30, 2025
@elena-shostak elena-shostak marked this pull request as ready for review January 30, 2025 11:39
@elena-shostak elena-shostak requested a review from a team as a code owner January 30, 2025 11:39
@elena-shostak elena-shostak added the ci:enable-fips-agent Use FIPS Agent Images for CI label Jan 30, 2025
@elena-shostak elena-shostak requested a review from a team as a code owner January 30, 2025 13:30
@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak elena-shostak removed the request for review from a team January 30, 2025 19:03
@elena-shostak
Copy link
Contributor Author

@elasticmachine merge upstream

@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak elena-shostak removed the ci:enable-fips-agent Use FIPS Agent Images for CI label Jan 30, 2025
@elena-shostak
Copy link
Contributor Author

/ci

1 similar comment
@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

kc13greiner
kc13greiner approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elena-shostak elena-shostak merged commit 9120c36 into elastic:main Jan 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kc13greiner kc13greiner kc13greiner approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elena-shostak @elasticmachine @kc13greiner @kibanamachine