Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] [Rule Form] Remove V1 Rule Form Flyout #209171

Draft
wants to merge 69 commits into
base: main
Choose a base branch
from
Draft

[Response Ops] [Rule Form] Remove V1 Rule Form Flyout #209171

wants to merge 69 commits into from
+1,093 −8,830

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jan 31, 2025

This PR is dependent on #206685

Summary

Closes #195211

Removes all old rule form flyout code, which should no longer be referenced at all after #206685

Checklist

Zacqary and others added 30 commits January 22, 2025 12:53
@Zacqary
Hide close button when show request is open
1ef801c
@Zacqary
Use EUI breakpoint variables for container breakpoints
1faf112
@Zacqary
Revert "Use EUI breakpoint variables for container breakpoints"
4cb5b1d 
This reverts commit 8d58b28.
@Zacqary
Decouple RuleForm component from react router
e5b287a
@Zacqary
Initially replace flyout in Discover plugin
74f59b7
@Zacqary
Replace add/edit rule flyouts with getRuleFormFlyout
dd6e167
@Zacqary
Remove missing import
6dd013d
@Zacqary
Add isServerless flag to rule flyout
69eb8fa
@Zacqary
Fix metadata typing
74d5339
@Zacqary
Fix initialMetadata error
646af0f
@Zacqary
Add flyout close confirm and no actions callout
d4c91d3
@Zacqary
Fix action UI display papercuts
2d61517
@kibanamachine @Zacqary
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
1ffea47 
…-fix'
@Zacqary
Fix typecheck
19f2fdc
@Zacqary
Fix bundle size
3e9ebe4
@Zacqary
Fix typecheck
70d4dab
@Zacqary
Lazy load rule form component from response ops package
9c4d831
@Zacqary
Fix lazy loading rule form
547c4da
@Zacqary
Begin fixing discover tests
c2174d6
@Zacqary
Fix button ids on discover test
4719faf
@Zacqary
Fix system actions test
51e33f9
@Zacqary
Fix get app menu header id
c25c283
@Zacqary
Fix cancelAlertFlyout function in ML anomaly tests
dc8c9ab
@Zacqary
Fix monitor alerts journey for closing rule form flyout
114e98a
@Zacqary
Create /components folder for common components
e3a0e7e
@Zacqary
Move confirm close modal to own component
dbc9712
@Zacqary
Replace flyout callouts and screens with confirm modals
fd7abec
@elasticmachine
Merge branch 'main' into 195211-replace-flyout
4dbc4f0
@Zacqary
Remove unused import
b0f977b
@Zacqary
Merge branch '195211-replace-flyout' of https://github.com/Zacqary/ki…
4b806ac 
…bana into 195211-replace-flyout
Zacqary added 22 commits January 27, 2025 12:43
@Zacqary
Fix uptime rule form flyout and observability rule params
52c6414
@Zacqary
Fix uptime tests
aa0287f
@Zacqary
Fix serverless search source test
9ef99b5
@Zacqary
Fix APM cypress
bb09a7d
@Zacqary
Add debug logs to accessibility testing
d182820
@Zacqary
Fix synthetics journey
118a154
@Zacqary
Fix APM cypress
b8a2e33
@Zacqary
Remove code path for experimental use of v1 flyout
09d456d
@Zacqary
Update synthetics journey
c89a707
@Zacqary
Update uptime synthetic test and skip discover accessibility test
565c974
@Zacqary
Merge remote-tracking branch 'upstream/main' into 195211-replace-flyout
def9107
@Zacqary
Unskip discover accessibility test
3f16b58
@Zacqary
Remove flyout loading check from discover test
27cb8b3
@Zacqary
Update synthetics tests
688c145
@Zacqary
Omit dataViews from RequiredRuleFormPlugins typedef
c3eff4f
@Zacqary
Add encryption key to discover accessibility test
3ef3181
@Zacqary
Fix uptime journey
756cfa8
@Zacqary
Merge remote-tracking branch 'upstream/main' into 195211-replace-flyout
95b14da
@Zacqary
Fix typecheck
aa0abd0
@Zacqary
Attempt synthetics test fix
990a73c
@Zacqary
Merge remote-tracking branch 'upstream/main' into 195211-replace-flyout
c4a2c9b
@Zacqary
Remove V1 Rule Form flyout
fc81cb4
@Zacqary Zacqary added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 backport:version Backport to applied version labels labels Jan 31, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@Zacqary Zacqary mentioned this pull request Jan 31, 2025
Open
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Rules] Use the new rule form to the create rules flyout
3 participants
@Zacqary @elasticmachine @kibanamachine