Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API test for get_alerts_dataset_info tool #212838

Closed
wants to merge 2 commits into from
Closed

Add API test for get_alerts_dataset_info tool #212838

wants to merge 2 commits into from
+629 −58

Conversation

sorenlouv
Copy link
Member

Follow-up to: #212077

This PR includes an API test that covers get_alerts_dataset_info and would have caught the bug fixed in #212077.

It also contains the following bug fixes:

  • Fix system message in select_relevant_fields
  • Change prompt in select_relevant_fields so that the LLM consistently uses the right format when responding.

@sorenlouv sorenlouv requested a review from a team as a code owner March 2, 2025 22:28
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Mar 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes labels Mar 2, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 2, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@sorenlouv sorenlouv closed this Mar 3, 2025
@sorenlouv sorenlouv deleted the fix-bug-get_alerts_dataset_info branch March 3, 2025 09:05
@sorenlouv
Copy link
Member Author

Replaced by https://github.com/elastic/kibana/pull/212858/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorenlouv @elasticmachine