Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move timefilter code ⇒ data plugin #44607

Merged
merged 12 commits into from
Sep 4, 2019
Merged

Move timefilter code ⇒ data plugin #44607

merged 12 commits into from
Sep 4, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Sep 2, 2019 •
edited
Loading

Summary

Part of #44377

Moved timefilter code to data plugin folder.
However, imports \ services are not rewired yet, to simplify PR!

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom added the release_note:skip Skip the PR/issue when compiling release notes label Sep 2, 2019
@lizozom lizozom self-assigned this Sep 2, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Sep 2, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom marked this pull request as ready for review September 3, 2019 11:41
@lizozom lizozom requested review from a team as code owners September 3, 2019 11:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom added the review label Sep 3, 2019
jgowdyelastic
jgowdyelastic approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

lukeelmers
lukeelmers reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, added two questions.

src/legacy/core_plugins/data/public/timefilter/timefilter.test.ts Show resolved Hide resolved
src/legacy/ui/public/timefilter/index.ts Show resolved Hide resolved
crob611
crob611 approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes look good 👍

@lizozom lizozom changed the title Move timefilter code to data plugin Move timefilter code ⇒ data plugin Sep 4, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 7049983 into elastic:master Sep 4, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Sep 4, 2019
Move timefilter code ⇒ data plugin (elastic#44607)
956b18d 
* import TimeRange from NP

* Update imports

* Update RefreshInterval imports to NP

* Some more imports

* Moved timefilter to data plugin
(didn't rewire service!)

* Fixed eslint error

* remove virtual mock

* kibana context import

* Fix 'Monitoring is turned off' test

* fix import
@lizozom lizozom mentioned this pull request Sep 4, 2019
Merged
@wylieconlon wylieconlon mentioned this pull request Sep 4, 2019
Merged
lizozom pushed a commit that referenced this pull request Sep 4, 2019
Move timefilter code ⇒ data plugin (#44607) (#44812)
2c5aa9d 
* import TimeRange from NP

* Update imports

* Update RefreshInterval imports to NP

* Some more imports

* Moved timefilter to data plugin
(didn't rewire service!)

* Fixed eslint error

* remove virtual mock

* kibana context import

* Fix 'Monitoring is turned off' test

* fix import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@crob611 crob611 crob611 approved these changes

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @crob611 @lukeelmers @jgowdyelastic