Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing types from kibana/{public,server} for x-pack TypeScript #46351

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

joshdover
Copy link
Contributor

Summary

This change adds the kibana/public and kibana/server import paths for TypeScript code in x-pack. This aligns with the aliases provided in OSS TypeScript code.

There is some overlap between this change and this discussion in #40446. I propose we go ahead and add this now because:

  • Importing types from Core is a very common usecase in the New Platform. Not having to do very long relative imports to the top of the repo's file tree is convenient.
  • If we move forward with the propose change in An alternative to relative imports for local source code #40446, changing these imports from kibana/public to @kibana/core/public or similar should be easy.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Sep 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants