-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify FIPS test runner environment for integration tests #17096
Open
donoghuc
wants to merge
2
commits into
elastic:feature/fedramp-high-8.x
Choose a base branch
from
donoghuc:integration-tests-setup
base: feature/fedramp-high-8.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Modify FIPS test runner environment for integration tests #17096
donoghuc
wants to merge
2
commits into
elastic:feature/fedramp-high-8.x
from
donoghuc:integration-tests-setup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes two small changes to the dockerfile used to define the fips test environment. Specifically it adds curl (which is required by integration tests), make (which is required by test setup) and turns off debug ssl logging as it is extremely noisy in logs and breaking some assumptions in tests about logfile content.
773d794
to
872cc99
Compare
Tracking with https://github.com/elastic/ingest-dev/issues/5074 |
Exploring elastic/ingest-dev#5088 and trying to get this to run in CI. Still a WIP as there are some duplicated commands and other things to clean up.
|
💔 Build Failed
Failed CI Steps
History
|
Need to sort out what is hanging in CI, but for FIPS part one locally on commit 71a886b i'm down to just these failures! Failures:
1) Beat Input Without TLS successfully send events
Failure/Error: @fixture = Fixture.new(__FILE__)
RuntimeError:
/logstash/qa/integration/services/filebeat_setup.sh FAILED with exit status pid 952 exit 127
Shared Example Group: "send events" called from ./specs/beats_input_spec.rb:98
# ./services/service.rb:36:in `setup'
# ./framework/fixture.rb:82:in `block in setup_services'
# ./framework/fixture.rb:81:in `setup_services'
# ./framework/fixture.rb:47:in `initialize'
# ./specs/beats_input_spec.rb:28:in `block in <main>'
# ./rspec.rb:36:in `<main>'
2) Beat Input With TLS Server auth successfully send events
Failure/Error: @fixture = Fixture.new(__FILE__)
RuntimeError:
/logstash/qa/integration/services/filebeat_setup.sh FAILED with exit status pid 952 exit 127
Shared Example Group: "send events" called from ./specs/beats_input_spec.rb:131
# ./services/service.rb:36:in `setup'
# ./framework/fixture.rb:82:in `block in setup_services'
# ./framework/fixture.rb:81:in `setup_services'
# ./framework/fixture.rb:47:in `initialize'
# ./specs/beats_input_spec.rb:28:in `block in <main>'
# ./rspec.rb:36:in `<main>'
3) Beat Input With TLS Mutual auth successfully send events
Failure/Error: @fixture = Fixture.new(__FILE__)
RuntimeError:
/logstash/qa/integration/services/filebeat_setup.sh FAILED with exit status pid 952 exit 127
Shared Example Group: "send events" called from ./specs/beats_input_spec.rb:162
# ./services/service.rb:36:in `setup'
# ./framework/fixture.rb:82:in `block in setup_services'
# ./framework/fixture.rb:81:in `setup_services'
# ./framework/fixture.rb:47:in `initialize'
# ./specs/beats_input_spec.rb:28:in `block in <main>'
# ./rspec.rb:36:in `<main>'
4) Install and run java plugin successfully runs a pipeline with an installed Java plugins
Got 2 failures:
4.1) Failure/Error: expect(execute.stderr_and_stdout).to match(/Installation successful/)
expected "Using bundled JDK: /logstash/build/logstash-8.18.0-SNAPSHOT/jdk\nERROR: Something went wrong when installing logstash-input-java_input_example, message: Received fatal alert: handshake_failure\n" to match /Installation successful/
Diff:
@@ -1 +1,2 @@
-/Installation successful/
+Using bundled JDK: /logstash/build/logstash-8.18.0-SNAPSHOT/jdk
+ERROR: Something went wrong when installing logstash-input-java_input_example, message: Received fatal alert: handshake_failure
# ./specs/install_java_plugin_spec.rb:53:in `block in <main>'
# /logstash/build/qa/integration/vendor/jruby/3.1.0/gems/logstash-devutils-2.6.2-java/lib/logstash/devutils/rspec/spec_helper.rb:47:in `block in <main>'
# ./rspec.rb:36:in `<main>'
4.2) Failure/Error: expect(removal.stderr_and_stdout).to match(/Successfully removed #{plugin_name}/)
expected "Using bundled JDK: /logstash/build/logstash-8.18.0-SNAPSHOT/jdk\nERROR: Operation aborted, cannot remove plugin, message: This plugin has not been previously installed\n" to match /Successfully removed logstash-input-java_input_example/
Diff:
@@ -1 +1,2 @@
-/Successfully removed logstash-input-java_input_example/
+Using bundled JDK: /logstash/build/logstash-8.18.0-SNAPSHOT/jdk
+ERROR: Operation aborted, cannot remove plugin, message: This plugin has not been previously installed
# ./specs/install_java_plugin_spec.rb:41:in `block in <main>'
# /logstash/build/qa/integration/vendor/jruby/3.1.0/gems/logstash-devutils-2.6.2-java/lib/logstash/devutils/rspec/spec_helper.rb:47:in `block in <main>'
# ./rspec.rb:36:in `<main>'
Finished in 5 minutes 12 seconds (files took 1.02 seconds to load)
33 examples, 4 failures
Failed examples:
rspec './specs/beats_input_spec.rb[1:1:1]' # Beat Input Without TLS successfully send events
rspec './specs/beats_input_spec.rb[1:2:1:1]' # Beat Input With TLS Server auth successfully send events
rspec './specs/beats_input_spec.rb[1:2:2:1]' # Beat Input With TLS Mutual auth successfully send events
rspec ./specs/install_java_plugin_spec.rb:50 # Install and run java plugin successfully runs a pipeline with an installed Java plugins
Randomized with seed 48078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This commit makes two small changes to the dockerfile used to define the fips test environment. Specifically it adds curl (which is required by integration tests) and turns off debug ssl logging as it is extremely noisy in logs and breaking some assumptions in tests about logfile content.
Related issues
Closes https://github.com/elastic/ingest-dev/issues/5074