Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow the use of 'integration' as data stream name #704

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

jsoriano
Copy link
Member

What does this PR do?

Disallow the use of integration as data stream name.

Why is it important?

Fleet creates a ingest pipeline for every package that would collide with the ingest pipelines created for data streams called integration.

See #699.

Checklist

Related issues

@jsoriano jsoriano self-assigned this Jan 29, 2024
@jsoriano jsoriano requested a review from a team as a code owner January 29, 2024 14:58
@jsoriano jsoriano requested a review from kpollich January 29, 2024 14:59
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jsoriano

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick turnaround on this!

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit a347e4d into elastic:main Jan 29, 2024
3 checks passed
@jsoriano jsoriano deleted the disallow-integration-data-stream-name branch January 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Change Proposal] Reserve package keyword for data stream/dataset values
4 participants