Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README.md #226

Closed
wants to merge 48 commits into from
Closed

docs: update README.md #226

wants to merge 48 commits into from

Conversation

eltociear
Copy link

unfortunatelly -> unfortunately

@eltociear
docs: update README.md
175a396 
unfortunatelly -> unfortunately
@elchininet
Copy link
Owner

Hi @eltociear,
I am using your PR as a test to improve the current workflows.
When everything is working properly, I'll merge it :)
Regards

@elchininet
Always install node modules
e32d8b9
@elchininet
Merge branch 'master' into patch-1
0468eab
@elchininet
Download the artifact in a directory
4dc88dd
@elchininet
Merge branch 'master' into patch-1
18c9060
@elchininet
Create a specific worflow for testing PR
f59deb1
@elchininet
Merge branch 'master' into patch-1
30fef12
@elchininet
Change PR test job name
eddcb5c
@elchininet
Merge branch 'master' into patch-1
700a3f7
@elchininet
Fix identation
843f84a
@elchininet
Merge branch 'master' into patch-1
de68dc1
@elchininet
Specify an on trigger
039dbc2
@elchininet
Merge branch 'master' into patch-1
5f5f867
@elchininet
Remove check_id
d194753
@elchininet
Merge branch 'master' into patch-1
860cd5f
@elchininet
Remove git-branch and git-commit from coveralls
e1746ac
@elchininet
Merge branch 'master' into patch-1
4314793
@elchininet
Remove id from checks action
ca7db95
@elchininet
Merge branch 'master' into patch-1
59e1b50
@elchininet
Use head_commit instead of head_sha
59fc4b8
@elchininet
Merge branch 'master' into patch-1
1f77522
@elchininet
Copy link
Owner

Hi @eltociear,
I am giving up for now, I'll cherry pick your commit to the master branch and I will try to solve the issue of MR from external forks later.

@elchininet
Copy link
Owner

@eltociear the change is already applied.
Thanks for the contribution and sorry for not being able to solve the issue with PR coming from forks.

@elchininet elchininet closed this Nov 26, 2024
@coveralls
Copy link

Coverage Status

coverage: 99.901%. remained the same
when pulling 843468f on eltociear:patch-1
into dba7aa0 on elchininet:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elchininet elchininet elchininet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eltociear @elchininet @coveralls