chore(compiler): migration to rollup + vitest (prep work for CJS/ESM dual bundles) #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 77b6700 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
changed the title
mmaietta
changed the title
mmaietta
force-pushed
the
explore/vitest-rollup-2
branch
from
0db5c46 to
3af1fcc
Compare
mmaietta
changed the title
…ackage for esm+cjs. This PR is the initial setup/migration to the new bundler + testing framework. Overall, vitest was a simple setup but rollup was encountering cyclical dependency issues, so a minor extraction of various functions to separate files was needed. _Note: All moved functions that were originally exposed via API to end-user developers have remained the same._ Additional changes: - `require` is now `await import` which required `createTargets` to be migrated to `async`. This was fine as the caller of `createTargets` is already an async function, so this simply was a matter of adding `await` to `createTargets` invocation - `ifAll` test helper function was removed. It would be triggered via env var ALL_TESTS, but we haven't used that env var in years. - Added ts-node to run `checkDeps` and `generate-schema` since we don't compile the `test` dir with rollup, vitest automatically is able to run it as-is.
mmaietta
force-pushed
the
explore/vitest-rollup-2
branch
from
28f0381 to
144b241
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…vitest-rollup-2 # Conflicts: # test/src/HoistedNodeModuleTest.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end goal here is to see if we can enable dual publishing of the package for esm+cjs. This PR is the initial setup/migration to the new bundler + testing framework.
Overall, vitest was a simple setup but rollup was encountering cyclical dependency issues, so a minor extraction of various functions to separate files was needed. Note: All moved functions that were originally exposed via API to end-user developers have remained the same.
Additional changes:
requireis nowawait importwhich requiredcreateTargetsto be migrated toasync. This was fine as the caller ofcreateTargetsis already an async function, so this simply was a matter of addingawaittocreateTargetsinvocationifAlltest helper function was removed. It would be triggered via env var ALL_TESTS, but we haven't used that env var in years.checkDepsandgenerate-schemasince we don't compile thetestdir with rollup, vitest automatically is able to run it as-is.