feat: allow usage of .cjs, .mjs, and type=module custom publishers
#8868
+381
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d9878fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
commented
Feb 17, 2025
beyondkmp
reviewed
Feb 17, 2025
…ppInfo` is created). clear listeners after build. enable listeners to be added as promises
…-publisher # Conflicts: # packages/electron-builder-squirrel-windows/src/SquirrelWindowsTarget.ts
beyondkmp
reviewed
Feb 20, 2025
| @@ -288,36 +288,36 @@ File `myBeforePackHook.js` in the project root directory: | |||
| } | |||
| ``` | |||
| */ | |||
| readonly beforePack?: Hook<BeforePackContext, any> | string | null | |||
| readonly beforePack?: Hook<BeforePackContext, void> | string | null | |||
There was a problem hiding this comment.
The second parameter for all Hooks is void. Given this, should we consider removing this void parameter for now and only keep the first parameter? We can always add it back later if needed.
| this.eventEmitter.on("beforePack", resolveFunction(type, this.config.beforePack, "beforePack"), "user") | ||
| this.eventEmitter.on("afterExtract", resolveFunction(type, this.config.afterExtract, "afterExtract"), "user") | ||
| this.eventEmitter.on("afterPack", resolveFunction(type, this.config.afterPack, "afterPack"), "user") | ||
| this.eventEmitter.on("afterSign", resolveFunction(type, this.config.afterSign, "afterSign"), "user") |
There was a problem hiding this comment.
Could we consider introducing a state machine in the future? If a certain state fails, it could revert to the previous state and retry?
| @@ -132,6 +132,9 @@ export function build(options: PackagerOptions & PublishOptions, packager: Packa | |||
| promise = publishManager.awaitTasks() | |||
| } | |||
|
|
|||
| return promise.then(() => process.removeListener("SIGINT", sigIntHandler)) | |||
| return promise.then(() => { | |||
| packager.clearPackagerEventListeners() | |||
There was a problem hiding this comment.
If any one of the states fails, will it be released here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8862
Adds
AsyncEventEmitter:emitresolveFunctionfor user hooks to the beginning of the packagerbuildprocess so users can detect errors early if import is incorrectAdds unit test to cover all core user-provided hooks