fix: use execFileSync when using a cmd with a path #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously execSync was used, taking the full command line as a single string. This would be misparsed if the path had spaces in it. For example "C:\Users\My Name\e\third_party\depot_tools\gn" would see "C:\Users\My" as the command. NB: the new code in e-build.js is cleaner, but it wasn't clear (to me, anyway) that the changed handling of escapes would work. FWIW I tested this change on both Win and POSIX.
MarshallOfSound
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously execSync was used, taking the full command line as a single string. This works great for commands like
git pullbut not great when we specify a command's pathname that can have a space in it. For exampleC:\Users\My Name\e\third_party\depot_tools\gnwould seeC:\Users\Myas the command.NB: the new code in e-build.js is cleaner, but it wasn't clear (to me, anyway) that the changed handling of escapes would work. FWIW I tested this change on both Win and POSIX.
Xref #133 and #134
CC @codebytere @MarshallOfSound