ci: skip Electron 25 #211
Merged
ci: skip Electron 25 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
approved these changes
Jan 23, 2025
ckerr
approved these changes
Jan 24, 2025
samuelmaddock
approved these changes
Jan 24, 2025
VerteDinde
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why, but there's a consistent failure in CI runs for this repo where the Electron v25 run hangs until it's killed by the timeout. Sometimes rerunning it can get a green run, but seems like 80% of the time it hangs, and it's always v25.
Since it's an unsupported version of Electron anyway, skip it so that we don't have consistent test failures.