Tests : ajout de PHPStan (#662)

* Add PHPStan package. run in CI

* Fix errors from Entities & Controllers

* fix errors in BookingController

* remove useless  from EntityService

* remove useless  from CommissionJoinOrLeaveEvent

* ToggleableHandler: handle() should return bool

* fix BeneficiaryService & MembershipService

* fix ShiftService

* fix SwipeCardEvent & TimeLogEventListener

* fix BasePathPicture

* fix Commands

* Remove unused code

* homogenise form error display

Co-authored-by: Albin PETIT <[email protected]>

.github/workflows/ci.yaml

@@ -40,6 +40,11 @@ jobs:
       - name: Install Composer dependencies
         run: composer install --no-progress --prefer-dist --optimize-autoloader
 
+      # PHPStan finds bugs in your code without writing tests
+      # https://github.com/phpstan/phpstan
+      - name: Run PHPStan code scan
+        run: vendor/bin/phpstan analyse src
+
       # Tests
       - name: Run unit and functional tests
         run: |

composer.json

@@ -41,10 +41,10 @@
         "vich/uploader-bundle": "^1.11"
     },
     "require-dev": {
+        "phpstan/phpstan": "^1.9",
         "phpunit/phpunit": "^7.5",
         "sensio/generator-bundle": "^3.1",
         "symfony/phpunit-bridge": "^4.4"
-
     },
     "scripts": {
         "symfony-scripts": [