Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deactivate account section in case of account managed externally. #8627

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 23, 2023

Type of change

Content

Hide deactivate account setting if account is manged externally.

Motivation and context

Closes #8619

Screenshots / GIFs

Tests

  • connect to a matrix.org account. Observe that you can deactivate the account from the app (general settings).
  • connect to a element.io account. Observe that you cannot deactivate the account from the app (general settings).

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from hughns August 23, 2023 15:09
@bmarty bmarty changed the title Hide deactivate account section in cas of account managed externally. Hide deactivate account section in case of account managed externally. Sep 12, 2023
@bmarty bmarty force-pushed the feature/bma/hideAccountDeactivation branch from 97a3dfb to d31c741 Compare September 12, 2023 14:28
@bmarty
Copy link
Member Author

bmarty commented Sep 12, 2023

@hughns I have updated the PR.

@bmarty bmarty requested a review from hughns September 12, 2023 14:29
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this locally and looks good.

@bmarty bmarty merged commit 8c1cc44 into develop Sep 14, 2023
18 of 19 checks passed
@bmarty bmarty deleted the feature/bma/hideAccountDeactivation branch September 14, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EA: The app should hide account deactivation in OIDC-aware mode
2 participants