-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy crypto support. #8656
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this huge cleanup 🎉 . Are we ready to merge this PR from a product POV?
...-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/RustCrossSigningService.kt
Outdated
Show resolved
Hide resolved
...-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/RustCrossSigningService.kt
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 2 Bugs 18.6% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, let's merge it!
Note: once merged, I will disable the requirement for |
Type of change
Content
Removed legacy (kotlin /libolm) crypto module, and updated CI workflows
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist