Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy crypto support. #8656

Merged
merged 16 commits into from
Nov 13, 2023
Merged

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Oct 2, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Removed legacy (kotlin /libolm) crypto module, and updated CI workflows

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@ElementBot
Copy link

ElementBot commented Oct 2, 2023

Warnings
⚠️

vector/build.gradle#L137 - A newer version of org.threeten:threetenbp than 1.4.0 is available: 1.4.4

⚠️

vector/build.gradle#L137 - A newer version of org.threeten:threetenbp than 1.4.0 is available: 1.4.4

⚠️

vector/build.gradle#L202 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0

⚠️

vector/build.gradle#L202 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0

⚠️

vector/build.gradle#L242 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L242 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L326 - A newer version of org.jetbrains.kotlin:kotlin-reflect than 1.8.21 is available: 1.8.22

⚠️

vector/build.gradle#L326 - A newer version of org.jetbrains.kotlin:kotlin-reflect than 1.8.21 is available: 1.8.22

Generated by 🚫 dangerJS against d045ced

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this huge cleanup 🎉 . Are we ready to merge this PR from a product POV?

Copy link

sonarcloud bot commented Nov 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 82 Code Smells

18.6% 18.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, let's merge it!

@bmarty
Copy link
Member

bmarty commented Nov 13, 2023

Note: once merged, I will disable the requirement for Runs all tests with rust crypto (28)

@bmarty bmarty merged commit 979324d into develop Nov 13, 2023
13 of 14 checks passed
@bmarty bmarty deleted the feature/bca/clean_up_legacy_crypto branch November 13, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants