Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reply fallbacks are about to go away completely (matrix-org/matrix-spec-proposals#2781, element-hq/element-web#28406) and Element will probably get a lot of complaints if rendering replies doesn't work correctly. According to @AmineI (in #8162 (comment)) just switching
formattedText
totakeFormatted()
may resolve the issue for text replies.I haven't tested this myself. If the fix works, I assume the problem is that element was assuming
formatted_body
is always present, even though it's not required. To test: send/plain text
as a reply using develop.element.io and ensure both the quote and reply text are visible in element android (the/plain
should preventformatted_body
being added to the message).Fixes #7445
Fixes #8162
Fixes #8460
Fixes #8866
Image replies will remain broken (#8432, #6570)