Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome page buttons styling from square to rounded #27479

Conversation

shivamb11
Copy link

Fixes: #27468

Changed buttons styling and added hover effect on them for improved user experience.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Before:
Screenshot 2024-05-15 195228

After:
Screenshot 2024-05-15 195205

@shivamb11 shivamb11 requested a review from a team as a code owner May 15, 2024 15:09
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 15, 2024
@t3chguy t3chguy requested a review from a team May 15, 2024 15:10
@florianduros
Copy link
Member

florianduros commented May 15, 2024

Thanks for you contribution.
The changes are design related, we will wait for the opinion of the design team on it.

@shivamb11
Copy link
Author

Sure thing. Glad to have worked on it.

@Hinaichigo
Copy link

Rounded doesn't mean necessarily better user experience. Round buttons and elements can be aesthetically distracting.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@richvdh richvdh changed the title Updated welcome page buttons styling from square to rounded Update welcome page buttons styling from square to rounded Nov 14, 2024
@MidhunSureshR
Copy link
Member

Closing this since it's not really enough that the buttons are rounded, they also need to match thematically with the rest of the application. The Design team will tackle this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons on the welcome page are different (squared) than the buttons on all other pages (round)
6 participants