Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolbar icons disappearing on the iPad after backgrounding the app #3521

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Nov 15, 2024

Fixes #1918 - Revert 1a12c729de521d2dcb664bed6b19a75ec139bede as #617 is no longer reproducible on iOS 18.

… is no longer reproducible on iOS 18.
@stefanceriu stefanceriu requested a review from a team as a code owner November 15, 2024 15:01
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team November 15, 2024 15:01
Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

codecov bot commented Nov 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
858 1 857 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 22.22% (Passed 28 times, Failed 8 times)

Stack Traces | 2.2s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 15, 2024
@stefanceriu stefanceriu changed the title Fixes #1918 - Revert 1a12c729de521d2dcb664bed6b19a75ec139bede as #6… Fix toolbar icons disappearing on the iPad after backgrounding the app Nov 15, 2024
@stefanceriu stefanceriu merged commit 9697d59 into develop Nov 15, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/navigationStackFixes branch November 15, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar icons disappear after hiding app on iPad
2 participants