Support adding a caption to media uploads. #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
changed the title
Generated by 🚫 Danger Swift against ee2803e |
pixlwave
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3531 +/- ##
===========================================
+ Coverage 78.64% 78.78% +0.14%
===========================================
Files 749 750 +1
Lines 62847 63003 +156
===========================================
+ Hits 49424 49635 +211
+ Misses 13423 13368 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Velin92
reviewed
Nov 18, 2024
ElementX/Sources/Screens/MediaUploadPreviewScreen/MediaUploadPreviewScreenViewModel.swift
Outdated
Show resolved
Hide resolved
Velin92
approved these changes
Nov 18, 2024
And send it's content to the media upload's caption.
…lbar) The scaledPadding/Offset/Frame modifiers now live in Compound.
pixlwave
force-pushed
the
doug/media-composer
branch
from
2c43913 to
316321d
Compare
|
Going to wait until after the RC before merging this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reuses the message composer to add captions to media files.
Closes #3508.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-18.at.17.20.27.mp4