Add image/jpeg caps to device filter to support MJPEG webcams #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbetschar
added
the
Bitesize
jeremypw
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out there is another capability needed to support some webcams which produce MJPEG streams. They don't advertise the
video/x-rawcapability but supportimage/jpeginstead: https://oz9aec.net/software/gstreamer/webcam-pixel-formats-and-gstreamer-caps-filtersThis PR makes sure we are filtering for any one of those two capabilities when looking for a supported device. This fixes #236 (see screenshot below) and might fix as well (needs testing from the corresponding users): #175, #151, #149, #121, #115