feat: asynciterable support #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PaulAsjes this wouldnt be overwritten right? |
PaulAsjes
requested changes
Feb 28, 2025
|
|
||
| async_client = AsyncElevenLabs() | ||
|
|
||
| def test_generate_stream() -> None: |
There was a problem hiding this comment.
No assertions? This test doesn't appear to do anything if there isn't a human listening in.
| from elevenlabs import AsyncElevenLabs | ||
| from elevenlabs import play | ||
|
|
||
| async_client = AsyncElevenLabs() |
There was a problem hiding this comment.
Since this is entirely new and isn't autogenerated (and so no autogenerated tests) I think this needs way more tests before we can ship it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off #358