Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the simulator #18

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Documentation for the simulator #18

merged 3 commits into from
Feb 19, 2024

Conversation

zahnooo
Copy link
Collaborator

@zahnooo zahnooo commented Feb 16, 2024

No description provided.

@zahnooo zahnooo force-pushed the feature/doc-simulator branch from c27ff6c to 81352d1 Compare February 16, 2024 16:25
- Relative image paths
- GitHub Alert syntax
- HTML figure for image captions
Copy link
Collaborator

@r-dent r-dent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice graphics! I made some adjustments on the syntax, though:

  • Use of relative paths for images. You can do that and it is actually recommended. You can now also preview the file with images.
  • Use of GitHub-styled Alert blocks. GitHub renders them nicely. And i would expect that GitBook would do also.
  • Use of <figure> tag for image captions. I expect it to look better in GitLab that way (Docs).

I hope that's okay.

@zahnooo zahnooo merged commit f1a69f4 into main Feb 19, 2024
1 check passed
@zahnooo zahnooo deleted the feature/doc-simulator branch February 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants