Adding onerror handler to shutil.rmtree function
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address a `PermissionError` on windows systems when invoking `shutil.rmtree` in `directory_cleaner`, the `onerror` function will change the permissions of the file to allow for write access. This may provide a brief buffer when deleting directories and files recursely due to a possible race condition; if the write permission error is actually present, then the `onerror` logic activates. Else, it serves as a passthrough.
|
Addresses #116. No further unit testing is needed. Adding build jobs to non-Linux platforms may be required via GH actions for subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address a
PermissionErroron windows systems when invokingshutil.rmtreeindirectory_cleaner, theonerrorfunction will change the permissions of the file to allow for write access.This may provide a brief buffer when deleting directories and files recursely due to a possible race condition; if the write permission error is actually present, then the
onerrorlogic activates. Else, it serves as a passthrough.