Unify exception management in QueueCommand #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->monitoring->endTransaction(); | ||
| } catch (BadResponse $e) { | ||
| // We got a 404 or server error. | ||
| $this->logger->error("{$this->getName()}: Item does not exist in API: {$item->getType()} ({$item->getId()})", [ |
There was a problem hiding this comment.
Pre-existing problem, but 404/410 requires processing (eg unindex, delete local copy).
There was a problem hiding this comment.
It does, the default is ignore (but this still writes an error log) like for search trying to index an unpublished article. Trying to keep existing behavior.
| 'item' => $item, | ||
| ]); | ||
| $this->monitoring->recordException($e, "Error in processing {$item->getType()} {$item->getId()}"); | ||
| } finally { | ||
| $this->queue->commit($item); |
There was a problem hiding this comment.
Pre-existing, but we never retry?
There was a problem hiding this comment.
Discussing with @nlisgo we could introduce a configurable whitelist of exceptions that are allowed to retry. Requires looking at actual traffic and see which errors are frequently raised to put them into the list.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueueCommandcatch()blocks in a single place and deduplicate themfinallyto ensurecommit()call happenscommit()calls in any scenariorelease()method