Removed nil default for option

elixir-nx · Oct 23, 2023 · ce1e47a · ce1e47a
1 parent 3a2b9a9
commit ce1e47a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/lib/scholar/metrics/discounted_cumulative_gain.ex b/lib/scholar/metrics/discounted_cumulative_gain.ex
@@ -12,8 +12,7 @@ defmodule Scholar.Metrics.DiscountedCumulativeGain do
 
   opts = [
     k: [
-      default: nil,
-      type: {:custom, Scholar.Options, :positive_number_or_nil, []},
+      type: {:custom, Scholar.Options, :positive_number, []},
       doc: "Truncation parameter to consider only the top-k elements."
     ]
   ]

diff --git a/lib/scholar/options.ex b/lib/scholar/options.ex
@@ -100,7 +100,4 @@ defmodule Scholar.Options do
     {:error,
      "expected metric to be a :cosine or tuple {:minkowski, p} where p is a positive number or :infinity, got: #{inspect(metric)}"}
   end
-
-  def positive_number_or_nil(nil), do: {:ok, nil}
-  def positive_number_or_nil(k), do: positive_number(k)
 end