Skip to content

Commit

Permalink
Remove unused second argument
Browse files Browse the repository at this point in the history
  • Loading branch information
josevalim committed Dec 18, 2023
1 parent e8fee47 commit f3b382b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion benchmarks/knn.exs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ inputs_knn = %{
Benchee.run(
%{
"kdtree" => fn x ->
kdtree = Scholar.Neighbors.KDTree.fit(x, Nx.axis_size(x, 0))
kdtree = Scholar.Neighbors.KDTree.fit(x)
Scholar.Neighbors.KDTree.predict(kdtree, x, k: 4)
end,
"brute force knn" => fn x ->
Expand Down
4 changes: 2 additions & 2 deletions lib/scholar/neighbors/kd_tree.ex
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ defmodule Scholar.Neighbors.KDTree do
## Examples
iex> Scholar.Neighbors.KDTree.fit(Nx.iota({5, 2}), 10)
iex> Scholar.Neighbors.KDTree.fit(Nx.iota({5, 2}))
%Scholar.Neighbors.KDTree{
data: Nx.iota({5, 2}),
levels: 3,
Expand Down Expand Up @@ -233,7 +233,7 @@ defmodule Scholar.Neighbors.KDTree do
iex> x = Nx.iota({10, 2})
iex> x_predict = Nx.tensor([[2, 5], [1, 9], [6, 4]])
iex> kdtree = Scholar.Neighbors.KDTree.fit(x, 20)
iex> kdtree = Scholar.Neighbors.KDTree.fit(x)
iex> Scholar.Neighbors.KDTree.predict(kdtree, x_predict, k: 3)
#Nx.Tensor<
s64[3][3]
Expand Down
6 changes: 3 additions & 3 deletions test/scholar/neighbors/kd_tree_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,21 @@ defmodule Scholar.Neighbors.KDTreeTest do

describe "predict knn" do
test "all defaults" do
kdtree = KDTree.fit(x(), 10)
kdtree = KDTree.fit(x())

assert KDTree.predict(kdtree, x_pred()) ==
Nx.tensor([[0, 6, 4], [5, 2, 9], [0, 9, 2], [5, 2, 7]])
end

test "metric set to {:minkowski, 1.5}" do
kdtree = KDTree.fit(x(), 10)
kdtree = KDTree.fit(x())

assert KDTree.predict(kdtree, x_pred(), metric: {:minkowski, 1.5}) ==
Nx.tensor([[0, 6, 2], [5, 2, 9], [0, 9, 2], [5, 2, 7]])
end

test "k set to 4" do
kdtree = KDTree.fit(x(), 10)
kdtree = KDTree.fit(x())

assert KDTree.predict(kdtree, x_pred(), k: 4) ==
Nx.tensor([[0, 6, 4, 2], [5, 2, 9, 0], [0, 9, 2, 5], [5, 2, 7, 4]])
Expand Down

0 comments on commit f3b382b

Please sign in to comment.