Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate json object #21

Merged
merged 77 commits into from
Nov 2, 2023
Merged

generate json object #21

merged 77 commits into from
Nov 2, 2023

Conversation

liesenf
Copy link
Contributor

@liesenf liesenf commented Apr 7, 2023 •
edited by bvreede
Loading

Acceptance criteria:

  • Conversation object should be dumpable to json
  • Corpus object should be dumpable to json

E.g.:

convo.to_json(name = "conversation", directory = "jsonfiles")
corpus.to_json(name = "corpus", directory = "jsonfiles")

Review:
Check the notebook "Getting Started with Scikit-talk" in the documentation for usage examples.

Closes #6

@bvreede bvreede mentioned this pull request Apr 7, 2023
Closed
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

55.0% 55.0% Coverage
0.0% 0.0% Duplication

@bvreede bvreede marked this pull request as ready for review November 1, 2023 15:09
@carschno carschno self-requested a review November 1, 2023 15:09
carschno
carschno reviewed Nov 1, 2023
View reviewed changes
sktalk/__init__.py Outdated Show resolved Hide resolved
carschno
carschno approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@carschno carschno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

sktalk/corpus/conversation.py Show resolved Hide resolved
sktalk/corpus/conversation.py Show resolved Hide resolved
sktalk/corpus/conversation.py Outdated Show resolved Hide resolved
sktalk/corpus/corpus.py Outdated Show resolved Hide resolved
sktalk/corpus/corpus.py Outdated Show resolved Hide resolved
sktalk/corpus/participant.py Outdated Show resolved Hide resolved
sktalk/corpus/write/writer.py Outdated Show resolved Hide resolved
tests/corpus/test_conversation.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

98.6% 98.6% Coverage
0.0% 0.0% Duplication

@bvreede bvreede merged commit 9399445 into main Nov 2, 2023
9 checks passed
@bvreede bvreede deleted the csv_to_json branch November 21, 2023 14:57
@bvreede bvreede mentioned this pull request Dec 1, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvreede bvreede bvreede left review comments

@carschno carschno carschno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build JSON corpus object
3 participants
@liesenf @carschno @bvreede