Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakebox #56

Merged
merged 1 commit into from
Feb 12, 2024
Merged

flakebox #56

merged 1 commit into from
Feb 12, 2024

Conversation

sectore
Copy link
Collaborator

@sectore sectore commented Feb 12, 2024

Update flake.nix to use Flakebox instead of Fedimint as input.

Needed to update to latest Rust (see #40 (comment))

cargo version
cargo 1.75.0 (1d8b05cdd 2023-11-20)

Notes:

sectore added a commit that referenced this pull request Feb 12, 2024
@sectore sectore marked this pull request as ready for review February 12, 2024 14:16
@sectore sectore requested a review from elsirion February 12, 2024 14:16
@sectore sectore mentioned this pull request Feb 12, 2024
Copy link
Owner

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough since it unblocks #40. I think we should fix our justfile though.

@@ -0,0 +1,109 @@
# THIS FILE IS AUTOGENERATED FROM FLAKEBOX CONFIGURATION
!include justfile.fedimint.just
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This file doesn't exist
  2. The !include syntax isn't supported anymore and is now called import

@dpc is this an upstream issue or are we holding it wrong?

Copy link

@dpc dpc Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest flakebox master has a fix for the syntax.

The file gets generated if you call flakebox install and only contains any imports if they were passed via config key in the flake.nix.

@sectore @elsirion

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To sum up: Call flakebox install and it should be gone. If it's still is something must be doing: https://github.com/fedimint/fedimint/blob/663dd0350ec0d265d77712c6fa85967a13b8a10b/flake.nix#L135

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #60

@elsirion
Copy link
Owner

Also big thanks to @dpc for building falkebox!

@elsirion elsirion merged commit 69175b8 into master Feb 12, 2024
1 check passed
@sectore sectore deleted the flakebox branch February 13, 2024 08:12
sectore added a commit that referenced this pull request Feb 13, 2024
* Leptos v0.6.5
* Use updated flake.nix borrowed from #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants