Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwind improvements #73

Merged
merged 11 commits into from
May 25, 2024
Merged

Tailwind improvements #73

merged 11 commits into from
May 25, 2024

Conversation

Kodylow
Copy link
Contributor

@Kodylow Kodylow commented Apr 2, 2024 •
edited
Loading

builds on prev PR, Made some tailwind improvements for the chrome extension:

image image

@elsirion
Copy link
Owner

elsirion commented Apr 3, 2024

The buttons could be a bit wider:

Screenshot 2024-04-03 at 11-07-03 Webimint

elsirion
elsirion reviewed Apr 3, 2024
View reviewed changes
Copy link
Owner

@elsirion elsirion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good changes, just a few regressions imo. I'd try going up to 20 characters for wallet names.

The create wallet form got a bit squashed:

Screenshot 2024-04-03 at 11-17-51 Webimint

src/components/wallet_selector.rs Outdated Show resolved Hide resolved
src/components/create_wallet.rs
Comment on lines +6 to +8
#[component]
pub fn CreateWallet<F>(on_select: F) -> impl IntoView
where
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor!

@elsirion elsirion merged commit 45e07ac into elsirion:master May 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsirion elsirion elsirion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kodylow @elsirion