Encodable curve #1
Open
+186
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-lebel
reviewed
Nov 14, 2024
Comment on lines
+1267
to
+1282
| digest::typenum::UInt< | ||
| digest::typenum::UInt< | ||
| digest::typenum::UInt< | ||
| digest::typenum::UInt< | ||
| digest::typenum::UInt< | ||
| digest::typenum::UInt<digest::typenum::UTerm, digest::consts::B1>, | ||
| digest::consts::B0, | ||
| >, | ||
| digest::consts::B0, | ||
| >, | ||
| digest::consts::B0, | ||
| >, | ||
| digest::consts::B0, | ||
| >, | ||
| digest::consts::B0, | ||
| >, |
There was a problem hiding this comment.
You can use typenum::consts::U32 instead of writing everything with bits like here. For large values that aren't in typenum::consts, you can use the typenum-consts crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are changing the implementation of PrimeField for Dalek (from using [u8,32] to using the new elliptic_curve::array::array<u8,32> structs. This is something that they will need to do upstream eventually, but there is no clear timeline. We need to make this change to have the version of Primefield used by Dalek be the same as the version used by other curves (k256 for example).
We are bumping versions of common crates to the versions used in async-mpc.
We are adding many implementations that are related to the EncodableCurve trait in async-mpc
The async-mpc PR is here: https://github.com/elusiv-privacy/async-mpc/pull/168