Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu4e: re-add removed mu4e-compose-begin/end-commands #785

Conversation

LemonBreezes
Copy link
Contributor

The commands mu4e-compose-begin and mu4e-compose-end were removed in commit
djcb/mu@85bfe76 of version 1.12.0 of mu. This commit re-adds these commands to the evil collection for mu4e.

@dschrempf
Copy link

Thanks!

Apparently an interactive functin needs to be changed to a non-interactive one:

modes/mu4e/evil-collection-mu4e.el:119:30:Error: ‘beginning-of-buffer’ is for interactive use only; use ‘(goto-char (point-min))’ instead.

@LemonBreezes LemonBreezes force-pushed the re-add-mu4e-compose-begin-end-commands branch from c117d9c to ed8d3a4 Compare March 6, 2024 05:08
@LemonBreezes
Copy link
Contributor Author

Thanks!

Apparently an interactive functin needs to be changed to a non-interactive one:

modes/mu4e/evil-collection-mu4e.el:119:30:Error: ‘beginning-of-buffer’ is for interactive use only; use ‘(goto-char (point-min))’ instead.

Ok! I just fixed it.

@meliache
Copy link
Contributor

meliache commented Mar 6, 2024

Great, I stumbled upon the same issue and cool that you fixed it already. This PR fixes #781, which you certainly know since you opened it, but it's lot linked to the issue, so I hereby mention it so that people who find the issue first find a link to this PR.

The removal seems to have been a by-product of trying to follow more closely Gnus and its message-mode, which has its own functions to go to the signature, body, etc, so maybe these mu4e-specific functions were deemed unnecessary. Thinking of that, we might even consider porting these functions to evil-collections-gnus. But for now, I think it's fine keeping it here in mu4e only as it's consistent with its old behavior.

@LemonBreezes LemonBreezes force-pushed the re-add-mu4e-compose-begin-end-commands branch from ed8d3a4 to 8f5a495 Compare March 7, 2024 00:56
The commands `mu4e-compose-begin` and `mu4e-compose-end` were removed in
commit
djcb/mu@85bfe76
of version 1.12.0 of mu.  This commit re-adds these commands to the evil
collection for mu4e.
@LemonBreezes LemonBreezes force-pushed the re-add-mu4e-compose-begin-end-commands branch from 8f5a495 to c84b746 Compare March 7, 2024 01:29
@condy0919
Copy link
Collaborator

Good job

@condy0919 condy0919 merged commit fe96b41 into emacs-evil:master Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants