-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle AUCTeX's new mode naming convention #41
Handle AUCTeX's new mode naming convention #41
Conversation
lsp-ltex.el
Outdated
@@ -50,7 +50,8 @@ https://github.com/valentjn/ltex-ls" | |||
|
|||
(defcustom lsp-ltex-active-modes | |||
'( text-mode | |||
bibtex-mode context-mode latex-mode | |||
bibtex-mode context-mode | |||
latex-mode LaTeX mode ;; AUCTeX 14+ has renamed latex-mode to LaTeX-mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing a - here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this, I did the fix quickly on GitHub and didn't even consider it as a possible mistake
If those major modes work, we should add them by default. |
Thanks! |
Just to let you know, I've made a bit of digging and I didn't see any Sorry for the late answer, and thanks again for maintaining this package ! |
Feel free to open PRs for these major modes! :) |
Hi, thanks for maintaining this package, it's great!
To quote this other pull request :
So I just added
LaTeX-mode
to the variablelsp-ltex-active-modes
and it's working.Also, I was wondering if we shouldn't add by default the other latex mode (i.e.
TeX-mode
,tex-mode
andyatex-mode
)