Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run test_dataset_on_hf only for changes and every 2 days #2201

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sam-hey
Copy link
Contributor

@sam-hey sam-hey commented Feb 28, 2025

ref: #2200
test: test_dataset_on_hf

It is just running in pr with changes in 'mteb/tasks/**.py'
or every 2 days

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

@isaac-chung isaac-chung changed the title ci: dont run test_dataset_on_hf in every pr ci: run test_dataset_on_hf only for changes and every 2 days Mar 1, 2025
Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam-hey thanks for putting this together. It looks good to me so far.

I was wondering if it would make more sense in the next iteration to run

  • everything once every 2 days (ok)
  • just the changed / added tasks in the PR (👈)

Would love to get @KennethEnevoldsen 's take here and on the original issue as well.

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - added a few suggestions, but nothing that changes behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants