-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run test_dataset_on_hf only for changes and every 2 days #2201
base: main
Are you sure you want to change the base?
ci: run test_dataset_on_hf only for changes and every 2 days #2201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-hey thanks for putting this together. It looks good to me so far.
I was wondering if it would make more sense in the next iteration to run
- everything once every 2 days (ok)
- just the changed / added tasks in the PR (👈)
Would love to get @KennethEnevoldsen 's take here and on the original issue as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - added a few suggestions, but nothing that changes behaviour.
Co-authored-by: Kenneth Enevoldsen <[email protected]>
Co-authored-by: Kenneth Enevoldsen <[email protected]>
ref: #2200
test: test_dataset_on_hf
It is just running in pr with changes in
'mteb/tasks/**.py'
or every 2 days
Code Quality
make lint
to maintain consistent style.Documentation
Testing
make test-with-coverage
.make test
ormake test-with-coverage
to ensure no existing functionality is broken.