fix: ember-source broken links #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-api-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lifeart
approved these changes
Jan 17, 2025
NullVoxPopuli
approved these changes
Jan 17, 2025
|
Looks like this still needs some work to fix the tests |
Hi @kategengler, I feel like tests have some flaky behaviour, Can we please rerun the CI just to be sure, If it fails, I will try to fix it. |
kategengler
reviewed
Jan 18, 2025
jaredgalanis
approved these changes
Jan 20, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the github-link helper to append -ember-source to the version string for v6.0.x patterns, ensuring correct link generation and preventing broken links
Changes