fix lint on es-button

ember-learn · Apr 20, 2020 · 0eb219f · 0eb219f
1 parent 6dec76c
commit 0eb219f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/addon/components/es-button.js b/addon/components/es-button.js
@@ -1,8 +1,10 @@
 import Component from '@glimmer/component';
+import { action } from '@ember/object';
 
 export default class EsButtonComponent extends Component {
   // default value
   _onClicked = () => {};
+  _type = "button";
 
   constructor() {
     super(...arguments);
@@ -14,8 +16,16 @@ export default class EsButtonComponent extends Component {
     } else {
       this._onClicked = this.args.onClicked;
     }
+
+    if(!this.args.type) {
+      // eslint-disable-next-line no-console
+      console.warn(new Error('Button created with no @type defined - defaulting to `type="button"`'));
+    } else {
+      this._type = this.args.type;
+    }
   }
 
+  @action
   buttonClicked() {
     this._onClicked();
   }

diff --git a/addon/templates/components/es-button.hbs b/addon/templates/components/es-button.hbs
@@ -1,12 +1,13 @@
 <button
   class={{if @secondary "es-button-secondary" "es-button"}}
   aria-label={{@label}}
-  onclick={{action this.buttonClicked}}
+  type={{this._type}}
   ...attributes
+  {{on "click" this.buttonClicked}}
 >
   {{#if hasBlock}}
     {{yield}}
   {{else}}
     {{@label}}
   {{/if}}
-</button>
+</button>