Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling team meeting 2023-12-19.md #564

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Tooling team meeting 2023-12-19.md #564

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4f6836
Tooling team meeting 2023-12-19.md
NullVoxPopuli Dec 19, 2023
fee45e3
Update 2023-12-19.md
NullVoxPopuli Dec 19, 2023
a72fdb7
Update 2023-12-19.md
NullVoxPopuli Dec 19, 2023
19e1dd4
Update 2023-12-19.md
NullVoxPopuli Dec 19, 2023
b37bf5e
Update st-embroider/2023/2023-12-19.md
NullVoxPopuli Dec 19, 2023
16892cc
Update st-embroider/2023/2023-12-19.md
NullVoxPopuli Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions st-embroider/2023/2023-12-19.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
# 2023-12-19

Note Taker: Preston
Time Keeper: Andrey Mikhaylov

## Attendees

Add yourself to the list if you attend and check the box!

- [x] Ed Falkner (EF)
- [x] Chris Manson (CM)
- [ ] Aaron Chambers (AC)
- [x] Alex (A)
- [x] Preston Sego (PS)
- [ ] Simon Ihmig (SI)
- [x] Katie Gengler (KG)
- [ ] Peter Meehan (PM)
- [x] Andrey Mikhaylov (AM)
- [ ] Godfrey Chan (GC)
- [x] Tommy JR (TJ)
- [ ] heroiceric
- [ ] Nick Schot (NS)
- [x] David Taylor
- [x] Peter Wagenet
- [x] Krystan
- [x] Ignace

## Topics

### content-tag indi

https://github.com/embroider-build/content-tag/issues/45

- content-tag _is_ byte ranges
- will add APIs to content-tag so that users don't need to do slicing
- https://github.com/embroider-build/content-tag/issues/39#issuecomment-1832443310
- potentially add to content-tag:
- charStart, charEnd, etc
- but wouldn't be needed if there is a `transform` callback capability
- Krystan volunteers to PR documentation

### GH actions magically turned on, on forks and unknowingly almost published a new unstable when sync-ing the fork

- when forking, if users have turned actions on by default for their profile/org, they'll need to manually turn actions off for that fork
- GH problem, GH needs more controls over this

### v2 addons gjs/gts module name exposing system config and bloating bundle size

- production path includes full system path (sometimes over 300 characters)
- issue report: https://github.com/embroider-build/embroider/issues/1592
- we want to remove the module name altogether because module name doesn't make sense for `<template>` components.
- add setting to remove?
- potentially in babel-plugin-ember-template-compilation
- RFC to remove `moduleName`, issue here: https://github.com/emberjs/rfcs/issues/940
- TODO: investigate -- does ember-intl use `moduleName`? we know the inspector does
- ember language server's ember-intl integration?
- Idea: `<template>` doesn't emit `moduleName`
- need to communicate that `moduleName` is optional / sometimes missing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already the case – precompile has moudleName marked as optional, technically, moduleName on the template is always present, but only because we default it to this string https://github.com/glimmerjs/glimmer-vm/blob/cb867e388d0de3547b3f4ebc10e2e92c95b75d7e/packages/%40glimmer/compiler/lib/compiler.ts#L128

So it would be non-breaking, at least technically speaking, to always set it to that string, and consumers should already be accounting for that

- move responsibility to the hbs -> js code
- `<template>` does not go through this path

### Let webpack handle test vs app layering

- https://github.com/embroider-build/ember-auto-import/issues/503
- https://github.com/embroider-build/ember-auto-import/pull/512
- Simon offers to potentially implement, Ed offers to pair with Simon
- Maybe Chris, too
- Alternative is more work-arounds in codebase
- Simon will ping Chris for status / context as well

### TypeScript team

- rollup TypeScript team into the tooling team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you did there 👀


### how are the ember-data types coming along?

- new apis will have types
- old apis may never have official types
- what is blocking from switching the blueprint to built-in types?
- Krystan to ask Chris (runspired)