docs: cleanup usage pattern for RequestManager configuration on store (…

…#9648)

guides/requests/examples/0-basic-usage.md

@@ -68,8 +68,7 @@ Lets see how we'd approach this request.
 import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 
-const fetch = new RequestManager();
-manager.use([Fetch]);
+const fetch = new RequestManager().use([Fetch]);
 
 export default fetch;
 ```

guides/requests/index.md

@@ -323,13 +323,9 @@ import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 
 class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([Fetch])
+    .useCache(CacheHandler);
 }
 ```
 
@@ -345,19 +341,16 @@ Additional handlers or a service injection like the above would need to be done
 consuming application in order to make broader use of `RequestManager`.
 
 ```ts
-import Store, { CacheHandler } from 'ember-data/store';
+import Store from 'ember-data/store';
+import { CacheHandler } from '@ember-data/store';
 import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 import { LegacyNetworkHandler } from '@ember-data/legacy-compat';
 
 export default class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([LegacyNetworkHandler, Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([LegacyNetworkHandler, Fetch])
+    .useCache(CacheHandler);
 }
 ```
 

packages/adapter/README.md

@@ -60,13 +60,9 @@ import RequestManager from '@ember-data/request';
 import { LegacyNetworkHandler } from '@ember-data/legacy-compat';
 
 export default class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([LegacyNetworkHandler]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([LegacyNetworkHandler])
+    .useCache(CacheHandler);
 }
 ```
 

packages/holodeck/README.md

@@ -107,8 +107,8 @@ import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 import { MockServerHandler } from '@warp-drive/holodeck';
 
-const manager = new RequestManager();
-manager.use([new MockServerHandler(testContext), Fetch]);
+const manager = new RequestManager()
+  .use([new MockServerHandler(testContext), Fetch]);
 ```
 
 From within a test this might look like:
@@ -121,8 +121,8 @@ import { module, test } from 'qunit';
 
 module('my module', function() {
   test('my test', async function() {
-    const manager = new RequestManager();
-    manager.use([new MockServerHandler(this), Fetch]);
+    const manager = new RequestManager()
+      .use([new MockServerHandler(this), Fetch]);
   });
 });
 ```

packages/request/README.md

@@ -63,8 +63,8 @@ import Fetch from '@ember-data/request/fetch';
 import { apiUrl } from './config';
 
 // ... create manager and add our Fetch handler
-const manager = new RequestManager();
-manager.use([Fetch]);
+const manager = new RequestManager()
+  .use([Fetch]);
 
 // ... execute a request
 const response = await manager.request({
@@ -441,13 +441,9 @@ import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 
 class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([Fetch])
+    .useCache(CacheHandler);
 }
 ```
 
@@ -463,19 +459,16 @@ Additional handlers or a service injection like the above would need to be done
 consuming application in order to make broader use of `RequestManager`.
 
 ```ts
-import Store, { CacheHandler } from 'ember-data/store';
+import Store from 'ember-data/store';
+import { CacheHandler } from '@ember-data/store';
 import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 import { LegacyNetworkHandler } from '@ember-data/legacy-compat';
 
 export default class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([LegacyNetworkHandler, Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([LegacyNetworkHandler, Fetch])
+    .useCache(CacheHandler);
 }
 ```
 

packages/request/src/-private/manager.ts

@@ -54,8 +54,8 @@ import Fetch from '@ember-data/request/fetch';
 import { apiUrl } from './config';
 
 // ... create manager and add our Fetch handler
-const manager = new RequestManager();
-manager.use([Fetch]);
+const manager = new RequestManager()
+  .use([Fetch]);
 
 // ... execute a request
 const response = await manager.request({
@@ -383,13 +383,9 @@ import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 
 class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([Fetch])
+    .useCache(CacheHandler);
 }
 ```
 
@@ -405,19 +401,16 @@ Additional handlers or a service injection like the above would need to be done
 consuming application in order to make broader use of `RequestManager`.
 
 ```ts
-import Store, { CacheHandler } from 'ember-data/store';
+import Store from 'ember-data/store';
+import { CacheHandler } from '@ember-data/store';
 import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 import { LegacyNetworkHandler } from '@ember-data/legacy-compat';
 
 export default class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([LegacyNetworkHandler, Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([LegacyNetworkHandler, Fetch])
+    .useCache(CacheHandler);
 }
 ```
 

packages/request/src/-private/types.ts

@@ -205,9 +205,8 @@ In the case of the `Future` being returned, `Stream` proxying is automatic and i
 Request handlers are registered by configuring the manager via `use`
 
 ```ts
-const manager = new RequestManager();
-
-manager.use([Handler1, Handler2]);
+const manager = new RequestManager()
+  .use([Handler1, Handler2]);
 ```
 
 Handlers will be invoked in the order they are registered ("fifo", first-in first-out), and may only be registered up until the first request is made. It is recommended but not required to register all handlers at one time in order to ensure explicitly visible handler ordering.

packages/serializer/README.md

@@ -60,13 +60,9 @@ import RequestManager from '@ember-data/request';
 import { LegacyNetworkHandler } from '@ember-data/legacy-compat';
 
 export default class extends Store {
-  requestManager = new RequestManager();
-
-  constructor(args) {
-    super(args);
-    this.requestManager.use([LegacyNetworkHandler]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([LegacyNetworkHandler])
+    .useCache(CacheHandler);
 }
 ```
 

packages/store/README.md

@@ -108,12 +108,9 @@ import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 
 export default class extends Store {
-  constructor() {
-    super(...arguments);
-    this.requestManager = new RequestManager();
-    this.requestManager.use([Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager()
+    .use([Fetch])
+    .useCache(CacheHandler);
 }
 ```
 

packages/store/src/-private/store-service.ts

@@ -491,12 +491,9 @@ export class Store extends BaseClass {
    * import Fetch from '@ember-data/request/fetch';
    *
    * class extends Store {
-   *   constructor() {
-   *     super(...arguments);
-   *     this.requestManager = new RequestManager();
-   *     this.requestManager.use([Fetch]);
-   *     this.requestManager.useCache(CacheHandler);
-   *   }
+   *   requestManager = new RequestManager()
+   *    .use([Fetch])
+   *    .useCache(CacheHandler);
    * }
    * ```
    *

packages/store/src/index.ts

@@ -82,11 +82,8 @@
  * import Fetch from '@ember-data/request/fetch';
  *
  * export default class extends Store {
- *   constructor() {
- *     super(...arguments);
- *     this.requestManager = new RequestManager();
- *     this.requestManager.use([Fetch]);
- *   }
+ *   requestManager = new RequestManager()
+ *    .use([Fetch]);
  * }
  * ```
  *

tests/ember-data__adapter/app/services/store.ts

@@ -18,12 +18,7 @@ import type { StableRecordIdentifier } from '@warp-drive/core-types';
 import type { TypeFromInstance } from '@warp-drive/core-types/record';
 
 export default class Store extends BaseStore {
-  constructor(args: unknown) {
-    super(args);
-    this.requestManager = new RequestManager();
-    this.requestManager.use([LegacyNetworkHandler, Fetch]);
-    this.requestManager.useCache(CacheHandler);
-  }
+  requestManager = new RequestManager().use([LegacyNetworkHandler, Fetch]).useCache(CacheHandler);
 
   createSchemaService(): ReturnType<typeof buildSchema> {
     return buildSchema(this);