ember-cli-update to latest blueprints (#2624)

.ember-cli

@@ -3,5 +3,5 @@
     Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
     rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
   */
-  "isTypeScriptProject": false
+  "isTypeScriptProject": true
 }

.github/workflows/build.yml

@@ -89,6 +89,7 @@ jobs:
           - ember-lts-3.28
           - ember-lts-4.8
           - ember-lts-4.12
+          - ember-lts-5.4
           - ember-release
           - ember-beta
           - ember-canary

.prettierrc.js

@@ -1,12 +1,20 @@
 'use strict';
 
 module.exports = {
+  plugins: ['prettier-plugin-ember-template-tag'],
   overrides: [
     {
-      files: '*.{js,ts}',
+      files: '*.{js,gjs,ts,gts,mjs,mts,cjs,cts}',
       options: {
         singleQuote: true,
       },
     },
+    {
+      files: '*.{gjs,gts}',
+      options: {
+        singleQuote: true,
+        templateSingleQuote: false,
+      },
+    },
   ],
 };

app/components/date-property-field.ts

@@ -7,10 +7,11 @@ export default class DatePropertyFieldComponent extends DatePicker {
   onInsert(element: HTMLInputElement) {
     super.onInsert(element);
 
+    // eslint-disable-next-line ember/no-runloop
     scheduleOnce('afterRender', this, this._openFlatpickr);
   }
 
-  _openFlatpickr() {
+  _openFlatpickr = () => {
     this.flatpickrRef?.open();
-  }
+  };
 }

app/components/list-content.ts

@@ -67,21 +67,21 @@ export default class ListContent extends Component<ListContentSignature> {
    */
   @action
   elementInserted() {
+    // eslint-disable-next-line ember/no-runloop
     schedule('afterRender', this, this.setupHeight);
   }
 
   /**
    * Set up the content height and listen to any updates to that property.
    */
-  @action
-  setupHeight() {
+  setupHeight = () => {
     this.contentHeight = this.layoutService.contentHeight;
     this.layoutService.on(
       'content-height-update',
       this,
       this.updateContentHeight,
     );
-  }
+  };
 
   /**
    * Triggered whenever the app's content height changes. This usually happens
@@ -90,8 +90,7 @@ export default class ListContent extends Component<ListContentSignature> {
    *
    * @param height The app's new content height
    */
-  @action
-  updateContentHeight(height: number) {
+  updateContentHeight = (height: number) => {
     this.contentHeight = height;
-  }
+  };
 }

app/components/list.js

@@ -13,9 +13,6 @@ export default class ListComponent extends Component {
   /**
    * Layout service used to listen to changes to the application
    * layout such as resizing of the main nav or object inspector.
-   *
-   * @property layoutService
-   * @type {Service}
    */
   @service('layout') layoutService;
 
@@ -120,6 +117,7 @@ export default class ListComponent extends Component {
     let oldSchema = this.oldSchema;
     let newSchema = this.schema;
     if (newSchema && newSchema !== oldSchema) {
+      // eslint-disable-next-line ember/no-runloop
       scheduleOnce('actions', this, this.setupColumns);
     }
     this.oldSchema = newSchema;
@@ -128,6 +126,7 @@ export default class ListComponent extends Component {
   @action
   elementInserted(el) {
     this.el = el;
+    // eslint-disable-next-line ember/no-runloop
     scheduleOnce('afterRender', this, this.setupColumns);
     this.onResize = () => {
       this.debounceColumnWidths.perform();
@@ -157,6 +156,7 @@ export default class ListComponent extends Component {
         arr.push({
           name,
           title: name,
+          // eslint-disable-next-line ember/no-runloop
           fn: bind(this, this.toggleColumnVisibility, id),
         });
         return arr;

app/components/object-inspector/property.ts

@@ -1,23 +1,29 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-return */
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { action, computed } from '@ember/object';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { alias, equal } from '@ember/object/computed';
 import { next } from '@ember/runloop';
 import parseText from 'ember-inspector/utils/parse-text';
 
-interface ObjectInspectorPropertyArgs {
-  model: any;
-  digDeeper: () => unknown;
-  gotoSource: () => void;
-  sendToConsole: () => void;
-  saveProperty: (
-    property: unknown,
-    value: unknown,
-    dataType: unknown
-  ) => unknown;
+interface ObjectInspectorPropertySignature {
+  Args: {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    model: any;
+    digDeeper: () => unknown;
+    gotoSource: () => void;
+    sendToConsole: () => void;
+    saveProperty: (
+      property: unknown,
+      value: unknown,
+      dataType: unknown,
+    ) => unknown;
+  };
 }
 
-export default class ObjectInspectorProperty extends Component<ObjectInspectorPropertyArgs> {
+export default class ObjectInspectorProperty extends Component<ObjectInspectorPropertySignature> {
   @tracked dateValue: Date | null = null;
   @tracked isDepsExpanded = false;
   @tracked isEdit = false;
@@ -66,10 +72,7 @@ export default class ObjectInspectorProperty extends Component<ObjectInspectorPr
 
   @computed('args.model.dependentKeys.[]', 'isCalculated')
   get hasDependentKeys() {
-    return (
-      this.args.model?.dependentKeys?.length &&
-      this.isCalculated
-    );
+    return this.args.model?.dependentKeys?.length && this.isCalculated;
   }
 
   get showDependentKeys() {
@@ -121,8 +124,11 @@ export default class ObjectInspectorProperty extends Component<ObjectInspectorPr
   }
 
   get cannotEdit() {
-    if (this.args.model.name === '...' || !this.isCalculated || this.readOnly) return true;
-    return !['type-string', 'type-number', 'type-boolean'].includes(this.args.model?.value?.type);
+    if (this.args.model.name === '...' || !this.isCalculated || this.readOnly)
+      return true;
+    return !['type-string', 'type-number', 'type-boolean'].includes(
+      this.args.model?.value?.type,
+    );
   }
 
   @action
@@ -143,12 +149,14 @@ export default class ObjectInspectorProperty extends Component<ObjectInspectorPr
       return;
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     let value = this.args.model.value.inspect;
 
     if (this.isString) {
       value = this._quotedString(value);
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     this.txtValue = value;
     this.isEdit = true;
   }
@@ -168,6 +176,7 @@ export default class ObjectInspectorProperty extends Component<ObjectInspectorPr
 
   @action
   finishedEditing() {
+    // eslint-disable-next-line ember/no-runloop
     next(() => {
       this.isEdit = false;
     });

app/components/object-inspector/sort-properties.js

@@ -1,5 +1,7 @@
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { map, sort } from '@ember/object/computed';
 import Component from '@glimmer/component';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { set, computed } from '@ember/object';
 import { A } from '@ember/array';
 
@@ -25,7 +27,10 @@ export default class SortProperties extends Component {
     let props = A(this.sorted);
     if (this.isArray) {
       const item = props.find((x) => x.name === 'length');
-      props.removeObject(item);
+      const index = props.indexOf(item);
+      if (index !== -1) {
+        props.splice(index, 1);
+      }
       props.splice(0, 0, item);
     }
     if (this.isArray && this.sorted.length > 100) {

app/components/promise-item.js

@@ -1,4 +1,7 @@
+/* eslint-disable ember/no-get */
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { computed, get } from '@ember/object';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { equal, gt, notEmpty } from '@ember/object/computed';
 import Component from '@glimmer/component';
 import { htmlSafe } from '@ember/template';
@@ -139,8 +142,7 @@ export default class PromiseItem extends Component {
     let startedAt =
       get(this, 'args.model.parent.settledAt') ||
       get(this, 'args.model.createdAt');
-    let remaining =
-      get(this, 'args.model.settledAt').getTime() - startedAt.getTime();
+    let remaining = this.args.model.settledAt.getTime() - startedAt.getTime();
     return remaining;
   }
 }