Mark dependent keys that updated #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to get a screenshot please? |
patricklx
force-pushed
the
improve-tracked-deps
branch
from
8a86283 to
de96fb2
Compare
|
added screemshot |
patricklx
force-pushed
the
improve-tracked-deps
branch
2 times, most recently
from
64852d5 to
f1d6bf5
Compare
this is the correct thing
patricklx
force-pushed
the
improve-tracked-deps
branch
from
f1d6bf5 to
a274e81
Compare
|
@RobbieTheWagner this is also ready |
patricklx
requested review from
RobbieTheWagner
and removed request for
RobbieTheWagner
|
Can you please explain what the idea is here? I don't find it very intuitive from the screenshot what it is that we are gaining. |
|
this is a follow up #2546 |
|
Are we able to make the title show up closer to the property that changed? It seems unclear what it belongs to in the screenshot. |
|
That's the native tooltip. I can try to make another screen shot with the cursor at the right position. Need to find the right keycombo... |
If it matches up to the correct item in reality, then that is fine with me. |
RobbieTheWagner
approved these changes
Apr 2, 2024
RobbieTheWagner
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this now also marks the changed dependent keys with a red text colour and adds a tooltip
Screenshots