Merge pull request #2232 from embroider-build/vite-ts-project

move @embroider/vite typescript build to a project reference

packages/core/package.json

@@ -13,7 +13,9 @@
   "main": "src/index.js",
   "typesVersions": {
     "*": {
-      "virtual": ["types/virtual"]
+      "virtual": [
+        "types/virtual"
+      ]
     }
   },
   "files": [
@@ -67,6 +69,7 @@
     "@types/jsdom": "^16.2.11",
     "@types/lodash": "^4.14.170",
     "@types/node": "^22.9.3",
+    "@types/qunit": "^2.19.12",
     "@types/resolve": "^1.20.0",
     "@types/semver": "^7.3.5",
     "@types/tmp": "^0.1.0",

packages/core/src/messages.ts

@@ -1,5 +1,8 @@
 import makeDebug from 'debug';
 import { format } from 'util';
+// @ts-expect-error we can't import the NestedHooks from qunit here
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+import type qunit from 'qunit';
 
 const todo = makeDebug('embroider:todo');
 const unsupported = makeDebug('embroider:unsupported');

packages/vite/.gitignore

@@ -5,3 +5,4 @@
 /tests/**/*.js
 /tests/**/*.d.ts
 /tests/**/*.map
+/dist/

packages/vite/package.json

@@ -4,8 +4,8 @@
   "type": "module",
   "exports": {
     ".": {
-      "default": "./index.mjs",
-      "types": "./index.d.ts"
+      "default": "./dist/index.js",
+      "types": "./dist/index.d.ts"
     }
   },
   "peerDependencies": {
@@ -44,10 +44,6 @@
     "vite": "^5.3.3"
   },
   "files": [
-    "index.mjs",
-    "index.d.ts",
-    "src/**/*.js",
-    "src/**/*.d.ts",
-    "src/**/*.js.map"
+    "dist"
   ]
 }

packages/vite/tsconfig.json

@@ -0,0 +1,11 @@
+{
+  "include": [
+    "./src/**/*.ts",
+    "./index.ts"
+  ],
+  "extends": "../../tsconfig-base.json",
+  "compilerOptions": {
+    "composite": true,
+    "outDir": "dist"
+  },
+}

tsconfig-base.json

@@ -0,0 +1,19 @@
+{
+  "compilerOptions": {
+    "target": "es2019",
+    "module": "nodenext",
+    "moduleResolution": "nodenext",
+    "declaration": true,
+    "typeRoots": ["types", "node_modules/@types"],
+    "esModuleInterop": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "sourceMap": true,
+    "inlineSources": true,
+    "experimentalDecorators": true,
+    "allowUnreachableCode": false,
+    "strict": true,
+    "skipLibCheck": true,
+    "useUnknownInCatchVariables": false,
+  },
+}

tsconfig.json

@@ -6,23 +6,7 @@
     "./test-packages/release/src/**/*.ts",
     "./tests/scenarios/**/*.ts"
   ],
-  "compilerOptions": {
-    "target": "es2019",
-    "module": "nodenext",
-    "moduleResolution": "nodenext",
-    "declaration": true,
-    "typeRoots": ["types", "node_modules/@types"],
-    "esModuleInterop": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "sourceMap": true,
-    "inlineSources": true,
-    "experimentalDecorators": true,
-    "allowUnreachableCode": false,
-    "strict": true,
-    "skipLibCheck": true,
-    "useUnknownInCatchVariables": false,
-  },
+  "extends": "./tsconfig-base.json",
   "exclude": [
     "node_modules",
     "packages/*/tmp",
@@ -34,9 +18,11 @@
     "tmp",
     "tests/scenarios/output",
     "packages/config-meta-loader/src",
-    "packages/router/src"
+    "packages/router/src",
+    "packages/vite"
   ],
   "references": [
-    { "path": "packages/config-meta-loader" }
+    { "path": "packages/config-meta-loader" },
+    { "path": "packages/vite" }
   ]
 }