downgrade ember-cli dependency to support a wider range of ember-source #2321
+26
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I doubt you can rely on a peer when you're executing via Can we just downgrade our dependency to 4.x? |
|
I guess that's probably ok 🤔 I don't think there is anything since 4.x that people would rely on for the prebuild. Let me try that 👍 |
mansona
force-pushed
the
peer-ember-cli
branch
from
a0ba22e to
fa7805e
Compare
mansona
changed the title
|
@ef4 I've tested this locally with my 3.28 app and it's working amazingly 🎉 |
mansona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time this won't be a problem for people since ember-cli can usually be upgraded independently of your app, but this breaks for anyone trying to use the codemod with [email protected] because of the bowerDependencies deprecation and removal in ember-cli@5
The issue I have here is that we kinda want a peer, but we don't actually install the codemod 🙈 doesnpxconsider the cwd when thinking about peers? What is the best way forward here? should I be doing an explicit resolve from cwd and dropping the dependency altogether? Thoughts?This PR downgrades the ember-cli dependency to 4.12 which gives us a balance of supporting 3.28 and also being the first version that works with an async function returned from ember-cli-build 😂 we're very lucky this version is so perfect