stop patching [email protected] #2323
Open
+2
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
old-versions
branch
from
68f2f48 to
b0457ae
Compare
mansona
force-pushed
the
old-versions
branch
from
1ea2598 to
b0457ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to work on the auto-patching of older ember-source versions and I noticed that in my empty generated app for [email protected] tests were passing 🤔 I wanted to verify in our CI that we still need to patch [email protected] and hopefully move the patching to be in a compat adapter 👍
Edit: turns out something has changed and we don't need to patch Ember 5.8 any more 🤔 that... is surprising 🫠
I'm going to keep going with older versions to see where the line is but I guess we can merge this now?