Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Maven artifacts under "m2_repo" #22

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

dmikurube
Copy link
Member

Maven artifacts (plugins) are to be installed in the "m2_repo" directory under the Embulk home directory, not directly in the Embulk home.

See EEP-4: System-wide Configuration by Embulk System Properties and Embulk Home https://github.com/embulk/embulk/blob/master/docs/eeps/eep-0004.md

This change is to follow the convention.

"m2_repo" can be configured by the "m2RepoRelative" notation in "installEmbulkRunSet". The default "m2_repo" is "lib/m2/repository".

Maven artifacts (plugins) are to be installed in the "m2_repo" directory
under the Embulk home directory, not directly in the Embulk home.

See EEP-4: System-wide Configuration by Embulk System Properties and Embulk Home
https://github.com/embulk/embulk/blob/master/docs/eeps/eep-0004.md

This change is to follow the convention.

"m2_repo" can be configured by the "m2RepoRelative" notation in "installEmbulkRunSet".
The default "m2_repo" is "lib/m2/repository".
@dmikurube dmikurube added this to the v0.2.0 milestone Jun 3, 2024
@dmikurube dmikurube requested a review from a team as a code owner June 3, 2024 07:44
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit da745f1 into main Jun 4, 2024
4 checks passed
@dmikurube dmikurube deleted the m2_repo-lib-m2-repository branch June 4, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants