-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install jruby-complete.jar, and set "jruby" #23
Conversation
e722d15
to
a34fa9e
Compare
Hmm, Windows + |
When using JRuby, Embulk expects to have an Embulk System Property "jruby" with a "file:" URI, such as "jruby=file:///path/to/jruby-complete.9.x.y.z.jar" See EEP-6: JRuby as Optional https://github.com/embulk/embulk/blob/master/docs/eeps/eep-0006.md This change is to add a new "jruby" notation in "installEmbulkRunSet" to download jruby-complete.jar, and set the "jruby" property.
@embulk/core-team It's ready for review. It'll make 1) download a jruby-complete jar, and 2) set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
(Minor)
Is it possible to test with my machine?
I tried ./gradlew publishToMavenLocal
and created the build.gradle
below,
But It couldn't find the plugin.
plugins {
id "org.embulk.runset" version "0.2.0-SNAPSHOT" // Just apply this Gradle plugin.
}
repositories {
// mavenCentral()
mavenLocal()
}
installEmbulkRunSet {
embulkHome file("path/to/embulk-home") // Set your Embulk home directory (absolute path) to install the Embulk plugins.
artifact "org.embulk:embulk-input-postgresql:0.13.2"
artifact group: "org.embulk", name: "embulk-input-s3", version: "0.6.0"
}
Thanks for taking a look!
Hmm, not sure. The Gradle plugin does not take care where the repository is. |
Thanks! LGTM👍 (Please tell me how to test this project on my machine laster) |
You may want to take a look at : https://docs.gradle.org/current/userguide/testing_gradle_plugins.html#manual-tests and contribute some manual testing environment in this repo. ;) |
Thanks! I'll try it. |
When using JRuby, Embulk expects to have an Embulk System Property
jruby
with afile:
URI, such asjruby=file:///path/to/jruby-complete.9.x.y.z.jar
See EEP-6: JRuby as Optional
https://github.com/embulk/embulk/blob/master/docs/eeps/eep-0006.md
This change is to add a new
jruby
notation ininstallEmbulkRunSet
to download jruby-complete.jar, and set thejruby
property.