Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install jruby-complete.jar, and set "jruby" #23

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Install jruby-complete.jar, and set "jruby" #23

merged 1 commit into from
Jun 11, 2024

Conversation

dmikurube
Copy link
Member

When using JRuby, Embulk expects to have an Embulk System Property jruby with a file: URI, such as jruby=file:///path/to/jruby-complete.9.x.y.z.jar

See EEP-6: JRuby as Optional
https://github.com/embulk/embulk/blob/master/docs/eeps/eep-0006.md

This change is to add a new jruby notation in installEmbulkRunSet to download jruby-complete.jar, and set the jruby property.

@dmikurube dmikurube added this to the v0.2.0 milestone Jun 3, 2024
@dmikurube dmikurube requested a review from a team as a code owner June 3, 2024 08:49
@dmikurube dmikurube force-pushed the jruby branch 2 times, most recently from e722d15 to a34fa9e Compare June 3, 2024 09:12
@dmikurube dmikurube marked this pull request as draft June 3, 2024 09:16
@dmikurube
Copy link
Member Author

Hmm, Windows + file: URL...

Base automatically changed from m2_repo-lib-m2-repository to main June 4, 2024 01:26
When using JRuby, Embulk expects to have an Embulk System Property "jruby"
with a "file:" URI, such as "jruby=file:///path/to/jruby-complete.9.x.y.z.jar"

See EEP-6: JRuby as Optional
https://github.com/embulk/embulk/blob/master/docs/eeps/eep-0006.md

This change is to add a new "jruby" notation in "installEmbulkRunSet"
to download jruby-complete.jar, and set the "jruby" property.
@dmikurube dmikurube marked this pull request as ready for review June 4, 2024 06:31
@dmikurube
Copy link
Member Author

@embulk/core-team It's ready for review. It'll make 1) download a jruby-complete jar, and 2) set the jruby Embulk System Property, available from the Gradle plugin.

Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

(Minor)
Is it possible to test with my machine?

I tried ./gradlew publishToMavenLocal and created the build.gradle below,
But It couldn't find the plugin.

plugins {
      id "org.embulk.runset" version "0.2.0-SNAPSHOT"  // Just apply this Gradle plugin.
}

repositories {
//    mavenCentral()
    mavenLocal()
}

installEmbulkRunSet {
    embulkHome file("path/to/embulk-home")  // Set your Embulk home directory (absolute path) to install the Embulk plugins.

    artifact "org.embulk:embulk-input-postgresql:0.13.2"
    artifact group: "org.embulk", name: "embulk-input-s3", version: "0.6.0"
}

@dmikurube
Copy link
Member Author

Thanks for taking a look!

I tried ./gradlew publishToMavenLocal and created the build.gradle below,
But It couldn't find the plugin.

Hmm, not sure. The Gradle plugin does not take care where the repository is.

@hiroyuki-sato
Copy link
Member

Thanks! LGTM👍 (Please tell me how to test this project on my machine laster)

@dmikurube dmikurube merged commit 734bf9d into main Jun 11, 2024
4 checks passed
@dmikurube dmikurube deleted the jruby branch June 11, 2024 07:46
@dmikurube
Copy link
Member Author

(Please tell me how to test this project on my machine laster)

You may want to take a look at : https://docs.gradle.org/current/userguide/testing_gradle_plugins.html#manual-tests

and contribute some manual testing environment in this repo. ;)

@hiroyuki-sato
Copy link
Member

Thanks! I'll try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants